Wagtail upgrade#412
Conversation
…ed as a ModuleNotFound but is used in blocks.py so is currently needed
| 'geocoder==1.38.*', | ||
| 'icalendar==4.0.*', | ||
| 'wagtail==2.11.*', | ||
| 'unidecode==1.*', |
There was a problem hiding this comment.
Is there a reason for this new dependency?
There was a problem hiding this comment.
When I ran pytest without it, it said ModuleNotFound and broke it. unidecode is used in the blocks.py file. Is there another way to bring it in so that it's recognized as a module?
There was a problem hiding this comment.
Ok, I'm guessing wagtail may have had it as a dependency and no longer uses it in 2.12. I would say first let's see where/why we are using it... maybe it can be removed. See if wagtail 2.12 release notes mentions it at all.
There was a problem hiding this comment.
Found a note in 2.11 actually: "Remove unidecode and use anyascii in for Unicode to ASCII conversion" You are currently using it in wagtail_flexible_forms > blocks.py and it's being used in get_slug.
There was a problem hiding this comment.
Please make the corresponding replacement to anyascii in our code, if possible, to remain closer to wagtail and eliminate the extra dependency. You can probably hunt down the original PR in wagtail to see what changes were made.
|
Abandoning in favor of #418 |
2 participants
For issue #409
Description of change
Updated required Wagtail version.
Also added unidecode in settings since it was not automatically found otherwise, used in blocks.py
Tests
Ran the pytest unit tests, all 56 passed with 40 deprecation warnings from Django (some of it from packages).
Also ran the testproject and it all still works, and CSS looks fine too.
Note that wagtail-import-export is no longer maintained but that will be a separate issue. It still seems to work for now, though.
**Will need to change version number but you can test it yourself first.